ASAN: Support coroutine context switching and stack tracing #4153
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For coroutine, we should use
__sanitizer_start_switch_fiber
which similar toVALGRIND_STACK_REGISTER
, see google/sanitizers#189 (comment) for details. If not fix this, asan will output warning:It will cause asan failed to get the stack, see
research/st/asan-switch.cpp
for example:After fix this issue, it should provide the full stack when crashing:
For primordial coroutine, if not set the stack by
st_set_primordial_stack
, then the stack is NULL and asan can't get the stack tracing. Note that it's optional and only make it fail to display the stack information, no other errors.