Recompile on Edit [RIP67] #73
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # build.sbt # project/Dependencies.scala # src/main/scala/com/ossuminc/riddl/plugins/idea/settings/RiddlIdeaSettings.scala # src/main/scala/com/ossuminc/riddl/plugins/idea/settings/RiddlIdeaSettingsComponent.scala # src/main/scala/com/ossuminc/riddl/plugins/idea/settings/RiddlIdeaSettingsConfigurable.scala # src/main/scala/com/ossuminc/riddl/plugins/idea/utils/ParsingUtils.scala # src/main/scala/com/ossuminc/riddl/plugins/idea/utils/ToolWindowUtils.scala # src/main/scala/com/ossuminc/riddl/plugins/idea/utils/utils.scala
…mandForEditor via DocumentListener [RIP-67]
reid-spencer
requested changes
Nov 25, 2024
There was a problem hiding this comment.
This is too long to review in detail at 5pm but I made some comments about your build that you should change. In general, the immense amount of logic you're dealing with for highlighting could probably be changed to a TopLevelParser.parseToTokens call and a match statement on each of the resulting tokens.
It helps my review greatly if you can put a video showing the visual results.
src/main/scala/com/ossuminc/riddl/plugins/idea/files/RiddlDocumentListener.scala
Outdated
Show resolved
Hide resolved
reid-spencer
approved these changes
Nov 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
parseRootWithURLsin Settings on applyparseNebulaContentsinrunCommandForEditorviaDocumentListener.documentChanged