Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add "first" scope to get_player_scores #606

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

minisbett
Copy link
Contributor

Describe your changes

Adds the "first" scope for first-place scores to the API v1, as the API v2 does not contain any implementation for this kind of stuff yet.

Checklist

  • I've manually tested my code

Copy link
Contributor

@tsunyoku tsunyoku left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignoring the fact i see this becoming SHIT slow on maps with many scores, this needs consideration/ignoration for restricted users as their first places should not count

@minisbett
Copy link
Contributor Author

minisbett commented Feb 15, 2024

ignoring the fact i see this becoming SHIT slow on maps with many scores, this needs consideration/ignoration for restricted users as their first places should not count

wait didnt I already add that to the query nvm

@tsunyoku
Copy link
Contributor

tsunyoku commented Sep 4, 2024

i still think this would be a nice feature to get in, however i'm still concerned about performance - we should be using an intermediary table that is inserted to on score submission if score.rank == 1 with a script to back-fill this table. this is going to be quite involved as there's events which might trigger changes to these - right now i can only think of (un)restriction. @minisbett would you be happy to do something along these lines?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants