K8s kafka mtls tutorial new screenshots and text edit #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tps://github.com/otterize/docs into sapir/k8s-kafka-mtls-tutorial-screenshots-update
orishoshan
reviewed
Sep 5, 2023
| 2. Calls from **[client-other]** are not declared (missing "white" inner line). | ||
| 3. Looking at the Kafka service, we can see that **[client]** has specific access configured (via Kafka ACLs) to perform `all` operations on the `mytopic` topic. | ||
| 1. The client intents are reflected as a green line from **[client]** to **[kafka]** ("Allowed"). | ||
| 2. Calls from **[client-other]** are not declared, therefore reflected as yellow line ("Would be blocked"). |
There was a problem hiding this comment.
Suggested change
| 2. Calls from **[client-other]** are not declared, therefore reflected as yellow line ("Would be blocked"). | |
| 2. Calls from **[client-other]** are not declared and would be blocked, therefore appearing as a yellow line, reflecting the fact it would be blocked. |
There was a problem hiding this comment.
Same here re the legend. Changed the phrasing to explain the meaning.
| 1. Kafka topic-specific intents from **[client]** are declared (solid black inner line and Kafka icon). | ||
| 2. Calls from **[client-other]** are not declared (missing "white" inner line). | ||
| 3. Looking at the Kafka service, we can see that **[client]** has specific access configured (via Kafka ACLs) to perform `all` operations on the `mytopic` topic. | ||
| 1. The client intents are reflected as a green line from **[client]** to **[kafka]** ("Allowed"). |
There was a problem hiding this comment.
Suggested change
| 1. The client intents are reflected as a green line from **[client]** to **[kafka]** ("Allowed"). | |
| 1. The connection from **[client]** to **[kafka]** is allowed, appearing as a green line, reflecting the fact that it is allowed. |
There was a problem hiding this comment.
I got that you were probably referring to the legend by adding ("Allowed"), but I guess the reader might not get that, so I replaced it with words pointing out the meaning.
|
|
||
| Since discovered intents from the network mapper don't specify what specific topics and operations clients are performing (or attempting to perform), the access graph cannot show information on what is being blocked vs allowed (red vs green). That feature is in development. | ||
|
|
||
| Also, the access graph shows information about the mTLS certificates (credentials) distributed to the various services, as long as [Cloud-managed credentials](/security#cryptographic-credentials) are being used. Visibility for certificates distributed through an in-cluster SPIRE is in development. | ||
|
|
||
| Click on **Kafka** service to get more details: |
There was a problem hiding this comment.
Suggested change
| Click on **Kafka** service to get more details: | |
| Click on the **Kafka** service to get more details: |
orishoshan
deleted the
sapir/k8s-kafka-mtls-tutorial-screenshots-update
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the K8s kafka mtls tutorial screenshots to match the new access graph design.
The changes we did: