Visual k8s cluster mapping tutorial - new screenshots #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orishoshan
reviewed
Sep 3, 2023
|
|
||
| Similarly, all the thick connecting lines between the services are green: none of these client calls would be blocked if enforcement were turned on. If one were red, that would tell you it would be blocked, as you might have guessed. | ||
| Similarly, all the thick connecting lines between the services are yellow: Client calls would be blocked if enforcement were turned on. If one were red, that would tell you it is blocked, as you might have guessed. |
There was a problem hiding this comment.
Suggested change
| Similarly, all the thick connecting lines between the services are yellow: Client calls would be blocked if enforcement were turned on. If one were red, that would tell you it is blocked, as you might have guessed. | |
| Similarly, all the connecting lines between the services are yellow: Client calls would be blocked if the services were [protected using a `ProtectedService` resource](/shadow-vs-active-enforcement#protected-services), however would not be blocked if enforcement were merely on. Click any line to see this. |
There was a problem hiding this comment.
@sapirwo Can you add a screenshot here to show the explanation on the edge, showing that if the service is protected, then it would block?
orishoshan
reviewed
Sep 3, 2023
| @@ -143,17 +143,15 @@ We also (as a default) told Otterize Cloud that there is a global default-deny n | |||
|
|
|||
| #### Blocking status | |||
|
|
|||
| Note that the locks themselves are green, indicating that you could now turn on enforcement without blocking any clients. | |||
| Note that the locks themselves are yellow, indicating that you could now turn on enforcement and blocking not intented clients. | |||
There was a problem hiding this comment.
Suggested change
| Note that the locks themselves are yellow, indicating that you could now turn on enforcement and blocking not intented clients. | |
| Note that the services themselves are yellow, indicating that access would be blocked if protection were enabled. |
@sapirwo Yellow actually means would be blocked, so it's not safe to turn on enforcement at this point!
orishoshan
reviewed
Sep 3, 2023
orishoshan
deleted the
sapir/visual-k8s-cluster-mapping-new-screenshots
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating the Visual k8s cluster mapping tutorial screenshots to match the new access graph design.
The changes we did:
Redesign the access graph nodes.
Redesign the access graph nodes info modal.
Redesign the access graph edges info modal.
Remove the focus mode.