Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Visual ibac kafka k8s tutorial - new screenshots #132

Conversation

sapirwo
Copy link
Contributor

@sapirwo sapirwo commented Aug 31, 2023

Description

Updating theVisual ibac kafka k8s tutorial screenshots to match the new access graph design.

The changes we did:

Redesign the access graph nodes.
Redesign the access graph nodes info modal.
Redesign the access graph edges info modal.
Remove the focus mode.

@sapirwo sapirwo changed the base branch from main to sapir/visual-ibac-network-policies-update-photos August 31, 2023 13:20
@orishoshan
Copy link
Contributor

LGTM

Copy link
Contributor

@usarid usarid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding how the access graph shows what's depicted here. Since the tutorial says we've declared all the needed intents from the other demo, why are we still showing yellow "would be blocked" indications everywhere? And why does the permissive KSC we're using lead to clients now being blocked?

@usarid usarid requested review from usarid and removed request for usarid September 10, 2023 01:27
@orishoshan orishoshan closed this Sep 20, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2023
@orishoshan orishoshan deleted the sapir/visual-ibac-kafka-k8s-new-screenshots branch September 20, 2023 14:22
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants