Rename external access flags #149
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orishoshan
reviewed
Oct 22, 2023
NetanelBollag
force-pushed
the
netanelb/rename-allow-external-policy-flags
branch
from
a9f6a32
to
e8ae43e
Compare
orishoshan
approved these changes
Nov 12, 2023
NetanelBollag
deleted the
netanelb/rename-allow-external-policy-flags
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Deprecate the flags
autoCreateNetworkPoliciesForExternalTrafficandautoCreateNetworkPoliciesForExternalTrafficDisableIntentsRequirementand replace them with the flagallowExternalTrafficwho receives the optionsifBlockedByOtterize,offoralways.Comparing the old flags to the
allowExternalTrafficifBlockedByOtterizetruefalseofffalsefalsealwaystruetrue