Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix links in intents-operator readme #207

Closed
wants to merge 1 commit into from

Conversation

victor-ufg
Copy link

@victor-ufg victor-ufg commented Mar 8, 2024

Description

There are a few links broken in the intents-operator configuration entry page, "Controlling access using the intents operator" section.
I am creating explicit heading ids to avoid future breaks (https://docusaurus.io/docs/next/markdown-features/toc#heading-ids)

@orishoshan
Copy link
Contributor

orishoshan commented Mar 9, 2024

Thanks @victor-ufg! These links are supposed to lead to the tutorials. We use a plugin called docusaurus-plugin-client-redirects to accommodate path changes, but it seems that when clicked from within Docusaurus, the redirects don't work due to client-side navigation 😱

During a recent reorganization of the docs we changed the paths and added redirects (if you click one of the broken links then refresh, you should find yourself redirected!), but looks like we do have to make sure to update all the links.

This is also supposed to be detected by the onBrokenMarkdownLinks setting in Docusaurus - I'm looking into why it allowed the build to go through despite being set to "throw"...

@orishoshan
Copy link
Contributor

It was a double whammy from the redirect plugin. It makes the broken link validation not work as that works on files, but the React router which performs the client-side navigation still doesn't know about them, so returns a 404.

@orishoshan
Copy link
Contributor

Fixed in #208

@orishoshan orishoshan closed this Mar 9, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Mar 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants