Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure IAM demo touchups: better explanations + add random suffix to storage account name #215

Merged
merged 1 commit into from
Mar 19, 2024

Conversation

amitlicht
Copy link
Contributor

@amitlicht amitlicht commented Mar 19, 2024

Description

Some small touchups in the Azure IAM demo following customer feedback:

  • Add a random suffix to the storage account name to avoid conflicting storage accounts
  • Add a note re Azure RBAC role assignments propagation time
  • Document client app logs when after creating a managed identity and before applying any role assignments
  • Reorganize some of the instructions such that the command to execute appears before the code block explaining it.

@amitlicht amitlicht marked this pull request as ready for review March 19, 2024 09:09
@amitlicht amitlicht enabled auto-merge (squash) March 19, 2024 10:41
@amitlicht amitlicht merged commit c6b210b into main Mar 19, 2024
2 checks passed
@amitlicht amitlicht deleted the amitlicht/azure_iam_demo_touchups branch March 19, 2024 10:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 19, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants