Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update the documentation of version command #80

Merged
merged 3 commits into from
May 16, 2023
Merged

Update the documentation of version command #80

merged 3 commits into from
May 16, 2023

Conversation

omris94
Copy link
Contributor

@omris94 omris94 commented May 16, 2023 •
edited
Loading

Description

Update the documentation of the CLI following changes in the otterize version command.
otterize/otterize-cli#114

@omris94 omris94 requested review from orishoshan and usarid May 16, 2023 10:22
usarid
usarid approved these changes May 16, 2023
View reviewed changes
Copy link
Contributor

@usarid usarid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Let's make sure we indicate, the release notes, that the api-version command is gone, not just deprecated.

@usarid usarid merged commit ca05b60 into main May 16, 2023
2 checks passed
@usarid usarid deleted the omris/update-version-command branch May 16, 2023 19:18
@github-actions github-actions bot locked and limited conversation to collaborators May 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@usarid usarid usarid approved these changes

@orishoshan orishoshan Awaiting requested review from orishoshan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@omris94 @usarid