Fix Kafka tutorial - change remaining topic names to mytopic #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
recheck |
|
I have read and understood the CLA and hereby agree to its terms by making this Pull Request Comment. |
|
recheck |
|
@orishavit So it turns out this was intentional -- the But this tutorial is pretty confusing, and we'll be reworking it. The other text changes you made, except for those in the KafkaServerConfig - are appropriate corrections. So I suggested a change for the KafkaServerConfig back to |
…-kafka-tutorial-topic
orishoshan
reviewed
May 22, 2023
| @@ -111,15 +111,15 @@ kubectl apply -f https://docs.otterize.com/code-examples/kafka-mtls/kafkaserverc | |||
| </Tabs> | |||
| </details> | |||
|
|
|||
| Upon applying the KafkaServerConfig, an ACL will configure Kafka to allow only authenticated access to the *transactions* topic by denying all anonymous access. | |||
| Upon applying the KafkaServerConfig, an ACL will configure Kafka to allow only authenticated access to the *mytopic* topic by denying all anonymous access. | |||
There was a problem hiding this comment.
Suggested change
| Upon applying the KafkaServerConfig, an ACL will configure Kafka to allow only authenticated access to the *mytopic* topic by denying all anonymous access. | |
| Upon applying the KafkaServerConfig, an ACL will configure Kafka to allow only authenticated access to the *transactions* topic by denying all anonymous access. |
orishoshan
reviewed
May 22, 2023
| This will be the base state, from which we will gradually roll out secure access to Kafka. | ||
|
|
||
| ```bash | ||
| kubectl logs -n kafka statefulset/kafka | grep "Processing Acl change" | grep ANONYMOUS | tail -n 1 | ||
| ``` | ||
| You should see the following output: | ||
| ``` | ||
| [2023-05-18 11:49:14,230] INFO Processing Acl change notification for ResourcePattern(resourceType=TOPIC, name=transactions, patternType=LITERAL), versionedAcls : Set(User:ANONYMOUS has DENY permission for operations: ALL from hosts: *, User:* has ALLOW permission for operations: ALL from hosts: *), zkVersion : 0 (kafka.security.authorizer.AclAuthorizer) | ||
| [2023-05-18 11:49:14,230] INFO Processing Acl change notification for ResourcePattern(resourceType=TOPIC, name=mytopic, patternType=LITERAL), versionedAcls : Set(User:ANONYMOUS has DENY permission for operations: ALL from hosts: *, User:* has ALLOW permission for operations: ALL from hosts: *), zkVersion : 0 (kafka.security.authorizer.AclAuthorizer) |
There was a problem hiding this comment.
Suggested change
| [2023-05-18 11:49:14,230] INFO Processing Acl change notification for ResourcePattern(resourceType=TOPIC, name=mytopic, patternType=LITERAL), versionedAcls : Set(User:ANONYMOUS has DENY permission for operations: ALL from hosts: *, User:* has ALLOW permission for operations: ALL from hosts: *), zkVersion : 0 (kafka.security.authorizer.AclAuthorizer) | |
| [2023-05-18 11:49:14,230] INFO Processing Acl change notification for ResourcePattern(resourceType=TOPIC, name=transactions, patternType=LITERAL), versionedAcls : Set(User:ANONYMOUS has DENY permission for operations: ALL from hosts: *, User:* has ALLOW permission for operations: ALL from hosts: *), zkVersion : 0 (kafka.security.authorizer.AclAuthorizer) |
orishoshan
reviewed
May 22, 2023
| @@ -12,7 +12,7 @@ spec: | |||
| keyFile: /etc/otterize-spire/key.pem | |||
| rootCAFile: /etc/otterize-spire/ca.pem | |||
| topics: | |||
| - topic: "transactions" | |||
| - topic: "mytopic" | |||
There was a problem hiding this comment.
Suggested change
| - topic: "mytopic" | |
| - topic: "transactions" |
orishoshan
approved these changes
May 22, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Some parts of the tutorial used the wrong Kafka topic name (probably was changed at some point), which caused the tutorial to not work cleanly. This PR changes all references to the topic name to
mytopic.