Support enabling enforcement per namespace while using defaultShadow enforcement mode #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
orishoshan
reviewed
Apr 9, 2024
src/operator/controllers/intents_reconcilers/protected_services/should_protect.go
Outdated
Show resolved
Hide resolved
1 task
orishoshan
approved these changes
Apr 9, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Until this PR, when one used shadowEnforcement mode, he could turn on enforcement only by using
protectedServices, a per-service CRD. In this PR I'm adding support for per-namespace configuration using the helm chart.References
otterize/helm-charts#194
otterize/docs#225
Testing
Checklist