Trim Server URL #375
Open
Trim Server URL #375
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -145,11 +145,13 @@ function URLInput({ initialURL, onValidURL }: URLInputProps) { | |||
| }, [initialURL]); | |||
|
|
|||
| function onChange(event: React.ChangeEvent<HTMLInputElement>) { | |||
| setCurrentURL(event.target.value); | |||
| let eventValue = event.target.value.trim(); | |||
There was a problem hiding this comment.
since eventValue won't change, I think it should be a const instead of let.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a Server URL is copy/pasted (from Discord, for example), it will sometimes add a space to the beginning or end of the URL and fail the URL Validation. This change trims the white space at the beginning and end of the string before verifying the URL.