chore(deps): bump type deps, fix lock, add node engine #439
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package.jsonsince there was no node version specified inREADMEorpackage.jsonreactandreact-domHi all! I was looking to contribute since I wanted to help support this awesome project. Just fixing some quick things I saw right away in the project, feedback welcome!
EDIT:
I used Node v12 as the engine since there was a types/node package for v12. Looks like the build has failed and the remote image expects 14 so I will adjust both the type dependency and the engine config to v14.
Adjusting the engine to match the build pipeline with:
~14seems to have worked 👍