Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Add support for invertWithDoc for subtypes #46

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions lib/json0.js
Original file line number Diff line number Diff line change
Expand Up @@ -65,13 +65,22 @@ json.create = function(data) {
return data === undefined ? null : clone(data);
};

json.invertComponent = function(c) {
json.invertComponent = function(c, doc) {
var c_ = {p: c.p};

var hasDoc = typeof doc !== 'undefined';
for (var i = 0; i < c.p.length; i++) {
var key = c.p[i];
doc = doc && doc[key];
}

// handle subtype ops
if (c.t && subtypes[c.t]) {
c_.t = c.t;
c_.o = subtypes[c.t].invert(c.o);
var subtype = subtypes[c.t];
if (hasDoc && typeof subtype.invertWithDoc === 'function') c_.o = subtype.invertWithDoc(c.o, doc);
else if (typeof subtype.invert === 'function') c_.o = subtype.invert(c.o);
else throw new Error("Subtype '" + c.t + "' is not invertible");
}

if (c.si !== void 0) c_.sd = c.si;
Expand Down Expand Up @@ -99,6 +108,15 @@ json.invert = function(op) {
return iop;
};

json.invertWithDoc = function(op, doc) {
var op_ = op.slice().reverse();
var iop = [];
for (var i = 0; i < op_.length; i++) {
iop.push(json.invertComponent(op_[i], doc));
}
return iop;
}

json.checkValidOp = function(op) {
for (var i = 0; i < op.length; i++) {
if (!isArray(op[i].p)) throw new Error('Missing path');
Expand Down
21 changes: 21 additions & 0 deletions test/json0.coffee
Original file line number Diff line number Diff line change
Expand Up @@ -222,6 +222,27 @@ genTests = (type) ->
assert.deepEqual [{p:[100], si:'hi'}], type.compose [{p:[100], si:'h'}], [{p:[101], si:'i'}]
assert.deepEqual [{p:[], t:'text0', o:[{p:100, i:'hi'}]}], type.compose [{p:[], t:'text0', o:[{p:100, i:'h'}]}], [{p:[], t:'text0', o:[{p:101, i:'i'}]}]

describe '#invertWithDoc()', ->
it 'passes the doc to the subtype', ->
op = null
doc = null

type.registerSubtype
name: 'invertible'
invertWithDoc: (o, d) ->
op = o
doc = d

type.invertWithDoc [{p: ['foo', 'bar'], t: 'invertible', o: [{increment: 1}]}], {foo: {bar: 5}}
assert.deepEqual [{increment: 1}], op
assert.deepEqual 5, doc

it 'throws if the subtype does not support inversion', ->
type.registerSubtype
name: 'not-invertible'

assert.throws -> type.invertWithDoc [{p: ['foo'], t: 'not-invertible', o: [{increment: 1}]}], {foo: 5}

it 'moves ops on a moved element with the element', ->
assert.deepEqual [{p:[10], ld:'x'}], type.transform [{p:[4], ld:'x'}], [{p:[4], lm:10}], 'left'
assert.deepEqual [{p:[10, 1], si:'a'}], type.transform [{p:[4, 1], si:'a'}], [{p:[4], lm:10}], 'left'
Expand Down