Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve error message when decompressing with missing extensions #516

Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 25 additions & 5 deletions CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,12 +8,32 @@ We follow the [Rust Official Code of Conduct](https://www.rust-lang.org/policies

Create [an issue](https://github.com/ouch-org/ouch/issues) or go to [Ouch Discussions](https://github.com/ouch-org/ouch/discussions).

# Adding a new feature
# Adding a brand new feature

Before creating a PR with a new feature, please, open an issue to suggest your addition.
Before opening the PR, open an issue to discuss your addition, this increases the chance of your PR being accepted.

This allows us to discuss the problem and solution, increasing the chance of your PR to be accepted.
# PRs

# Don't forget to
- Pass all CI checks.
- After opening the PR, add a [CHANGELOG.md] entry.

- In your PR, add a CHANGELOG.md entry.
# Updating UI tests

In case you need to update the UI tests.

- Run tests with `insta` to create the new snapshots:

```sh
cargo insta review # or
cargo insta review -- ui # useful filter
```

- Now, review the diffs you just generated.

```sh
cargo insta review
```

- You can commit them now.

[CHANGELOG.md]: https://github.com/ouch-org/ouch
159 changes: 136 additions & 23 deletions Cargo.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

1 change: 1 addition & 0 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ clap_mangen = "0.2.13"
[dev-dependencies]
assert_cmd = "2.0.12"
infer = "0.15.0"
insta = "1.31.0"
parse-display = "0.8.2"
proptest = "1.2.0"
rand = { version = "0.8.5", default-features = false, features = ["small_rng", "std"] }
Expand Down
Loading