feat: Add comic book aliases #835
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
md9753
force-pushed
the
main
branch
4 times, most recently
from
453871f to
691b97f
Compare
Added aliases to extensions.rs and tests/mime.rs, updated snapshots to match, included changes in README
|
Was very confused as to why clippy-checks was failing despite no issues on my end, no changes to the file mentioned in the logs, and no problems with other PRs. Turns out it's a new lint for Rust v1.89 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #831
Several archive formats have commonly-used aliases for storing comic books. This PR adds those aliases for the formats Ouch already supports:
I'm very new to Rust, so a close eye when looking this over would be appreciated.