perf: don't read 7z file to mem when not necessary #860
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoid reading entire 7z file into memory when it's not chained with other compression formats.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the list code to avoid loading an entire 7z archive into memory when not necessary. This fixes a performance regression introduced in #819.
The aforementioned PR fixed a bug with nested archive formats, where the
SevenZipcode tried to read the source file from disk rather than the decompressed stream it should've been reading. This PR reintroduces the original read-from-disk behavior whenSevenZipis the sole archive format. This is okay since we don't have to worry about nested compression when there is only one format.I tested this by:
cargo test