fix decompression without dir

[valoq]

Addresses #958

Sorry for the duplicate PR, git hates me today

[valoq]

I changed the decompression behavior that was added in 0.7.1 back to the one in 0.6.1 where archived decompressed in the current directory are written into a new directory with the archive name.

Why extracting the a new dir is better:

• it provides a way better user experience that does not accidentally mess up the cwd
• it matches user expectations from previous version
• it avoid breaking scripts that rely on the previous expectations
• is is a crucial dependency for moving forward with DRAFT: Add landlock support #723: by using an extraction directory, we can 1. create the new dir, 2. restrict write to cwd and parents and only whitelist the extraction dir, 3. extract the archive (dangerous)

Edit:
I realized that this behavior was provided by smart unpack which was removed. Going open an issue to discuss this specific issue for a future change

This PR now only fixes the issue with the missing --dir option

Edit2: added the solution discussed in #963

[valoq]

This PR now implements the decompression as discussed in #963

[valoq]

I will add some more tests to ensure this does not overlook any edge cases

[marcospb19]

Alright 👍, when you're done maybe I'll add a test too.

[valoq]

Ok, the tests are now all successful. This should be ready to be merged

[marcospb19]

You also fixed ouch decompress file.tar --dir .

majestic...

I'll add a test for that to ensure it's not broken in the future.

[marcospb19]

@valoq I pushed 2 new tests I'd like you to take a look and review in the last commit.

We can't cover all the scenarios nicely, now when --dir points to CWD, it'll also overwrite without asking, and it is a little inconsistent when compared to --dir pointing to other folders, that's not a big problem, just something I thought I'd add a test to ensure the behavior isn't changed unexpectedly.

To entirely solve this, we'd need to check for conflicts on every single file extracted, that's possible and I was working on that on another branch but it sounds simpler than it really is, there is a lot of emergent complexity for merging files on conflicts and correctly decompressing files even when a parent folder was renamed, by taking over the responsibility of conflict handling we also have to add more code to check for vulnerabilities that crates check for us.

---

Well anyways, please review the extra code and tell me if you see any problem, I think it's great for the scope of this PR, and the rest can be addressed properly later.

Signed: a929d4c4e

[marcospb19]

Just did a rebase to solve conflicts.

[valoq]

Well anyways, please review the extra code and tell me if you see any problem, I think it's great for the scope of this PR, and the rest can be addressed properly later.

LGTM