Handle GNUSparse archive entries during tar decompression#975
Open
kilianbartz wants to merge 2 commits intoouch-org:mainfrom
Open
Handle GNUSparse archive entries during tar decompression#975kilianbartz wants to merge 2 commits intoouch-org:mainfrom
kilianbartz wants to merge 2 commits intoouch-org:mainfrom
Conversation
Collaborator
|
Hi @kilianbartz, If you don't mind, could you add a simple e2e test for this case? This will help ensure that the behavior doesn't break in the future (e.g., during refactors or dependency updates). Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, compressing files into a tar archive via
ouch compressmay createGNUSparsearchive entries if appropriate, since the tar crate'sBuilderis initialized with thesparseoption set totrue. However, during decompression, this entry type is not handled which leads to silently skipped archive entries.Handling this entry type using
unpack_inmatches the decompression result of GNU tar for sparse archive entries.