Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ROS2 crashes when standby mode is set and then set to normal #288

Closed
mtswisher opened this issue Feb 7, 2024 · 2 comments
Closed

ROS2 crashes when standby mode is set and then set to normal #288

mtswisher opened this issue Feb 7, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@mtswisher
Copy link

mtswisher commented Feb 7, 2024

Describe the bug
The ROS2 driver will crash if the service /ouster/set_config is called with OPERATING_MODE: STANDBY
The nodelet will no longer receive additional queries and issuing a SIGTERM to the operating shell exits with additional error codes.

To Reproduce
Steps to reproduce the behavior (steps below are just an example):

  1. Setup working ROS2 environment from README

  2. ros2 launch ouster_ros sensor.launch.xml sensor_hostname:=os-122319000734.local launch node

  3. Validate node is publishing data through RVIZ

  4. Issue the following service command: ros2 service call /ouster/set_config ouster_sensor_msgs/srv/SetConfig "{config_file: 'test.json'}" test_3.json where test.json contains operating mode STANDBY
    image

  5. Issue the following service command: ros2 service call /ouster/set_config ouster_sensor_msgs/srv/SetConfig "{config_file: 'test.json'}" test_3.json where test.json contains operating mode NORMAL

  6. Query a service for a response:
    image
    This query will hang indefinitely

  7. Issuing SIGTERM to the original node fails with the following error: [ERROR] [os_driver-1]: process[os_driver-1] failed to terminate '10.0' seconds after receiving 'SIGTERM', escalating to 'SIGKILL'
    image

  • Ouster Sensor? OS1
  • Ouster Firmware Version? 3.0.1
  • ROS version/distro?humble
  • Operating System? Ubuntu 22.04
  • Machine Architecture? x86x64
  • git commit hash: commit 66d6b9f
@mtswisher mtswisher added the bug Something isn't working label Feb 7, 2024
@Samahu Samahu self-assigned this Feb 7, 2024
@Samahu
Copy link
Contributor

Samahu commented Feb 8, 2024

@mtswisher thank you for the detailed report. I have identified the root cause of the problem and will submit a fix soon.

@Samahu
Copy link
Contributor

Samahu commented Feb 9, 2024

Resolved by #292 and #293

@Samahu Samahu closed this as completed Feb 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants