Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ROS-288: ROS2 crashes when standby mode is set and then set to normal [FOXY] #292

Merged
merged 2 commits into from
Feb 9, 2024
Merged

ROS-288: ROS2 crashes when standby mode is set and then set to normal [FOXY] #292

merged 2 commits into from
Feb 9, 2024

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Feb 8, 2024 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Use timeout when waiting for packets to be proceed in case no packets are coming

Validation

  • functionality sustained
  • launch a ros2 node then perform a set_config call with STANDBY mode, see the driver idles
  • perform a follow set_config call this time with NORMAL mode and verify that driver resumes

@Samahu Samahu added the enhancement New feature or request label Feb 8, 2024
@Samahu Samahu self-assigned this Feb 8, 2024
@Samahu Samahu requested a review from mtswisher February 8, 2024 23:53
@Samahu Samahu mentioned this pull request Feb 9, 2024
Merged
@Samahu Samahu changed the title ROS-288: ROS2 crashes when standby mode is set and then set to normal ROS-288: ROS2 crashes when standby mode is set and then set to normal [FOXY] Feb 9, 2024
@Samahu Samahu merged commit 68dc12f into ros2-foxy Feb 9, 2024
2 checks passed
@Samahu Samahu deleted the ROS-288_ROS2_crashes_when_standby_mode_is_set_and_then_set_to_normal_FOXY branch February 9, 2024 17:42
@Samahu Samahu mentioned this pull request Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@twslankard twslankard twslankard approved these changes

@mtswisher mtswisher Awaiting requested review from mtswisher

@celentes celentes Awaiting requested review from celentes

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Samahu @twslankard