SW-4859: enable having multiple components of same-type under same process #108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bexcite
approved these changes
May 2, 2023
kairenw
approved these changes
May 2, 2023
|
I'm testing this, and am just getting into a loop where the init id of one of two lidars keeps changing and it just keeps reactivating it. |
|
Nevermind: it was because I was setting the same ports for both lidars |
Samahu
deleted the
SW-4859-enable-having-multiple-components-of-same-type-under-same-process
branch
|
I did verify it to work with two sensors one container before marking the PR as ready, also have verified using two cloud nodes on a single sensor with a single container. |
|
Yes I have also verified this to work. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
Summary of Changes
Validation