Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SW-4993: Reduce the publish rate of imu tf transforms #134

Merged
merged 1 commit into from
May 12, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented May 10, 2023

Related Issues & PRs

Summary of Changes

  • Reduce the publish rate of tf transforms by publishing IMU TF transforms at the same rate as LIDAR TF transforms

Note:
Using StaticTransformPublisher is the proper thing to do but due to an issue that exists(or existed) in ROS1 which causes it to generate tons of warnings that couldn't be silenced as noted in #9 and also based on my own experience; so as a compromise I kept everything pretty much as is but reduced the publish rate of IMU TF transforms by publishing them at the same time as LIDAR TF transforms.

Validation

  • Before this change the total publish rate of TF messages generated by ROS driver would be at 120+ Hz.
  • Launch a sensor with the ouster driver in one terminal and run a tf monitor in another terminal and observe the frequency of published TF transforms. The total publish rate shouldn't exceed 20 Hz for lidar modes with 10 Hz FPS and 40 Hz for lidar modes with 20 Hz FPS.

@Samahu Samahu self-assigned this May 10, 2023
@Samahu Samahu added the enhancement New feature or request label May 10, 2023
@Samahu Samahu changed the title Reduce the publish rate of imu tf transforms SW-4993: Reduce the publish rate of imu tf transforms May 10, 2023
@Samahu Samahu mentioned this pull request May 10, 2023
@Samahu Samahu marked this pull request as ready for review May 12, 2023 14:35
@Samahu Samahu merged commit 3f01e1d into master May 12, 2023
@Samahu Samahu deleted the SW-4993-limit-the-publish-rate-of-ros-tf-transform branch May 12, 2023 14:35
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this pull request Nov 18, 2023
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this pull request Nov 19, 2023
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this pull request Dec 27, 2023
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this pull request Jan 23, 2024
tobii-ho pushed a commit to StarkStrom-Driverless/ouster-ros that referenced this pull request Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

High TF Broadcast Rate
2 participants