Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW-5617: resolve issue with crash on exist in ros-1 driver #243

Merged
merged 7 commits into from
Nov 8, 2023
Merged

SW-5617: resolve issue with crash on exist in ros-1 driver #243

merged 7 commits into from
Nov 8, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Oct 26, 2023

Related Issues & PRs

  • N/A

Summary of Changes

  • Stop publishers and any threads on nodelets destroy

Validation

  • connect to a sensor, verify no crash reported on shutdown (either via ctrl+c or rosnode kill)

@Samahu Samahu added the bug Something isn't working label Oct 26, 2023
@Samahu Samahu self-assigned this Oct 26, 2023
@Samahu Samahu marked this pull request as ready for review November 8, 2023 16:13
@Samahu Samahu merged commit 8c8ccfd into master Nov 8, 2023
2 checks passed
@Samahu Samahu deleted the SW-5617-resolve-issue-with-crash-on-exist-in-ros-1-driver branch November 8, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexcite bexcite bexcite approved these changes

@twslankard twslankard Awaiting requested review from twslankard

@celentes celentes Awaiting requested review from celentes

@pallenouster pallenouster Awaiting requested review from pallenouster

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

Assignees

@Samahu Samahu

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Samahu @bexcite