Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SW-5622: Bump up ouster_client to 20231031 release #249

Merged
merged 5 commits into from
Nov 9, 2023
Merged

SW-5622: Bump up ouster_client to 20231031 release #249

merged 5 commits into from
Nov 9, 2023

Conversation

Samahu
Copy link
Contributor

@Samahu Samahu commented Nov 3, 2023 •
edited
Loading

Related Issues & PRs

Summary of Changes

  • Bump up ouster_client to 20231031 release
  • Remove ouster-ros melodic from build checks since it is no longer compatible (due to spdlog)

Validation

Ensure all functionality sustained with no drawbacks per testing procedures for ouster-ros

@Samahu Samahu added the enhancement New feature or request label Nov 3, 2023
@Samahu Samahu self-assigned this Nov 3, 2023
@Samahu
Copy link
Contributor Author

Samahu commented Nov 7, 2023

So apparently the build fails on ouster_ros melodic because spdlog under Ubuntu 18.04 does not support spdlog formatting. This means we'd have to modify the SDK to not use this method or just disable ROS melodic altogether.

@Samahu
Copy link
Contributor Author

Samahu commented Nov 7, 2023 •
edited
Loading

So apparently the build fails on ouster_ros melodic because spdlog under Ubuntu 18.04 does not support spdlog formatting. This means we'd have to modify the SDK to not use this method or just disable ROS melodic altogether.

Given that the SDK drops support for the Ubuntu 18.04 on October of this year (ouster-lidar/ouster-sdk#532) I don't see another option but to also drop support for melodic (completely) starting with version 0.10.

This may upset some of ouster-ros users

@Samahu Samahu marked this pull request as ready for review November 7, 2023 20:44
Samahu and others added 2 commits November 8, 2023 11:46
@Samahu
Squashed commit of the following:
897e96a 
    * Gracefully stop the driver on exit (or node kill)
    * Update version and CHANGELOG
@Samahu
Merge branch 'master' into SW-5622-bump-up-ouster-client-to-20231031-…
9dedaac 
…for-ouster-ros-1
@Samahu
Copy link
Contributor Author

Samahu commented Nov 9, 2023 •
edited
Loading

Resolved all conflicts and performed necessary sanity checks

@Samahu Samahu merged commit bb2ab24 into master Nov 9, 2023
1 check passed
@Samahu Samahu deleted the SW-5622-bump-up-ouster-client-to-20231031-for-ouster-ros-1 branch November 9, 2023 23:09
@Samahu Samahu mentioned this pull request Nov 13, 2023
Closed
@Samahu Samahu mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bexcite bexcite bexcite approved these changes

@twslankard twslankard Awaiting requested review from twslankard

@celentes celentes Awaiting requested review from celentes

@pallenouster pallenouster Awaiting requested review from pallenouster

@chrisbayruns chrisbayruns Awaiting requested review from chrisbayruns

Assignees

@Samahu Samahu

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Increase RCVBUF_SIZE to prevent package loss
2 participants
@Samahu @bexcite