-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ROS-119: ouster-ros driver automatic reconnection #361
Conversation
} | ||
|
||
void create_laser_scan_pubs() { | ||
// NOTE: always create the 2nd topic |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We used to create the 2nd topics only if the current profile supported DUAL returns, however, since the user can potentially switch between different profile on reconnection it wouldn't bound well that we create and destroy topics when switching between dual vs non-dual for downstream consumers.
Would be good to have max_reattempts parameter for some cases - it makes sense to have when sensor connection has been dropped, may not make sense to have when first spinning up the sensor though. |
Related Issues & PRs
Summary of Changes
auto_udp
if startup config didn't set an addressTODO(s)
handle sensor reconfiguration from a cold startproperly handle config change outside of the ros driverKnown Issues
Validation
attempt_reconnect
parameter and verify that it works as expected for the following scenarios