Merged
Conversation
|
|
||
| option(BUILD_VIZ "Turn off building VIZ" OFF) | ||
| option(BUILD_PCAP "Turn off building PCAP" OFF) | ||
| option(BUILD_OSF "Turn off building OSF" OFF) |
Collaborator
There was a problem hiding this comment.
Out of scope, but the language on these comments is confusing. The wording implies that when set to OFF it builds these options.
matthew-lidar
approved these changes
Sep 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related Issues & PRs
RAWoption for proc_mask #238Summary of Changes
os_driverproc_maskto optionally publish the raw packets when using os_driverTODO(s)
cartesianT&point_cloud_composemethodsValidation
destaggeris set to false verify the driver doesn't destagger the published point cloudorganizedis set to false verify that the published point cloud isn't 2Dmin_rangeandmax_rangeand observe the point cloud shrink accordingly./ouster/imu_packetsand/ouster/lidar_packetappear when RAW flag is passed toos_driver