Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use standard encrypted PKCS#8 for SecKeyPair importing and export #70

Merged
merged 7 commits into from
Jun 9, 2023

Conversation

kdubb
Copy link
Collaborator

@kdubb kdubb commented Jun 9, 2023

No description provided.

kdubb added 7 commits June 9, 2023 14:40
… schemas

Also moves types from ShieldPKCS into ShieldX509 to stop circular library references
…ilience

This is required to ensure when attempting to decode structures decrypted with an incorrect key an error is thrown.

This is because PKCS#8 requires AES-CBC which is not authenticated and cannot itself detect invalid passwords.
@sonarcloud
Copy link

sonarcloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 3 Code Smells

84.4% 84.4% Coverage
0.0% 0.0% Duplication

@kdubb kdubb merged commit 54f50fe into main Jun 9, 2023
7 checks passed
@kdubb kdubb deleted the fix/pkcs8 branch June 9, 2023 23:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant