Add accessibility support to SecKey, SecKeyPair, SecCertificate & SecIdentity
#78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… & `SecIdentity` Allows selecting accessibility (i.e. `kSecAttrAccessible`) when generating or saving items. As a requirement we add `kSecUseDataProtectionKeychain` to keychain requests. This has the benefit of normalizing keychain access across macOS & iOS, tvOS, watchOS); allowing the removal of the last usage of `#if os(macOS)/#endif` when accessing the keychain. `SecKey.attributes()` now retrieves _all_ attributes from using `SecItemCopyMatching` instead of `SecKeyCopyAttributes`; this is backward compatible with previous functionality with _more_ attributes. `SecKey.keyAttributes()` can be used to get previous _smaller_ list of attributes (which may also be faster).
kdubb
force-pushed
the
feature/accessibility
branch
from
60aeb9e to
8a16c9b
Compare
kdubb
force-pushed
the
feature/accessibility
branch
2 times, most recently
from
59e41c3 to
5d8a76e
Compare
kdubb
force-pushed
the
feature/accessibility
branch
from
5d8a76e to
9e5dccf
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows selecting accessibility (i.e.
kSecAttrAccessible) when generating or saving items.As a requirement we add
kSecUseDataProtectionKeychainto keychain requests. This has the benefit of normalizing keychain access across macOS & iOS, tvOS, watchOS); allowing the removal of the last usage of#if os(macOS)/#endifwhen accessing the keychain.SecKey.attributes()now retrieves all attributes from usingSecItemCopyMatchinginstead ofSecKeyCopyAttributes; this is backward compatible with previous functionality with more attributes.SecKey.keyAttributes()can be used to get previous smaller list of attributes (which may also be faster).