chore: pnpm update, test suite fixes, Playwright e2e, CI gate - #658
chore: pnpm update, test suite fixes, Playwright e2e, CI gate#658MaXoS-Agent wants to merge 6 commits into
Conversation
Verification
Ready for review when you have a moment. |
|
Added Playwright e2e runner in latest commit: ```bash workspace must be running (e.g. scripts/start-stable.sh)pnpm test:e2e or: HERMES_WORKSPACE_URL=http://127.0.0.1:3000 pnpm test:e2e``` 7 browser tests in `e2e/` — separate from Vitest unit suite (`pnpm test`). |
Recommendations for upstream (from desk testing on M2 Max)Hi Eric — PR aside, here’s what we found running Merge candidate (this PR)
Bugs / drift we hit (fixed in PR, worth upstream awareness)1. 2. Vitest was running Playwright 3. Hub-search API contract drift
4. Chat message list tests stale Suggested follow-ups (not in PR)
Environment notes (operator, not repo)
Happy to split this PR into smaller chunks (deps-only / tests-only / e2e-only) if that’s easier to review. |
|
Opened tracking issue for follow-ups: #659 Latest commit syncs hub-search route header comment (limit 500 + offset). CI test gate change (remove |
|
Re-authenticated |
- Exclude e2e Playwright specs from Vitest; add localStorage setup - Point MCP store/route tests at HERMES_HOME/workspace paths - Update hub-search mocks for offset param and 500 result cap - Refresh i18n, chat composer, and message list expectations
- Add @playwright/test devDependency and playwright.config.ts - Scripts: test:e2e, test:e2e:ui (Vitest continues to exclude e2e/) - Conductor specs use Playwright baseURL (HERMES_WORKSPACE_URL or :3000)
Document limit 1..500 and offset query param. Refs outsourc-e#659
Remove continue-on-error so test failures block PRs. Refs outsourc-e#659
|
PR refreshed: rebased on latest |
- Replace deprecated xterm packages with @xterm/xterm + addons - Bump vite 7→8, vitest 3→4, TanStack router/start 1.166→1.167 - verify: pnpm test (725/725), pnpm build
Summary
Desk maintenance pass on Apple Silicon (M2 Max): dependency refresh, 725/725 unit tests green, Playwright e2e runner, and CI hardening.
Tracking issue for follow-ups: #659
Changes (5 commits)
1.
chore: pnpm update dependenciesPatch/minor bumps across the workspace (React 19.2.7, Playwright 1.61.1, Tailwind 4.3.1, Electron 40.10.5, etc.). Major pins (TanStack, Vite 8, Vitest 4) intentionally deferred.
2.
test: fix suite drift after workspace state dir and API changesHERMES_HOME/workspace/(matchesgetStateDir())e2e/**from Vitest; addvitest.setup.tslocalStorage mockoffsetarg + limit clamp 500buildDisplayEntriesexpectations updated3.
chore: add Playwright e2e test runner@playwright/test+playwright.config.tspnpm test:e2e,pnpm test:e2e:uiHERMES_WORKSPACE_URLorhttp://127.0.0.1:30004.
docs: sync hub-search route comment with implementationDocuments
limit1..500 andoffsetquery param.5.
ci: enforce pnpm test as hard gateRemoves
continue-on-erroron the test job so failures block merges.Verification
Out of scope (see #659)
xterm→@xterm/*migrationgetStateDir()test helperContributor: @MaXoS-Agent — happy to split into smaller PRs if preferred.