Skip to content

Fix dashboard fallback auth in profile browsing (#499 regression) #710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JulianMendezw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix dashboard fallback auth in profile browsing (#499 regression) #710

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 9 additions & 21 deletions src/server/profiles-browser.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,15 +198,6 @@ function getDashboardUrl(): string | undefined {
return url || undefined
}

function getDashboardToken(): string | undefined {
return (
process.env.HERMES_API_TOKEN?.trim() ||
process.env.CLAUDE_API_TOKEN?.trim() ||
process.env.CLAUDE_DASHBOARD_TOKEN?.trim() ||
undefined
)
}

async function fetchDashboardProfiles(): Promise<{
profiles: Array<ProfileSummary>
activeProfile: string
Expand All @@ -215,12 +206,13 @@ async function fetchDashboardProfiles(): Promise<{
if (!dashboardUrl) return null

try {
const token = getDashboardToken()
const headers: Record<string, string> = {}
if (token) headers['Authorization'] = `Bearer ${token}`

const response = await fetch(`${dashboardUrl}/api/profiles`, {
headers,
// The dashboard's /api/profiles route only accepts its ephemeral
// per-boot session token (scraped from its root HTML), not a static
// bearer token — dashboardFetch() already implements that scrape/retry
// dance (see gateway-capabilities.ts) and is the same helper the
// skills/toggle-skill dashboard proxies use.
const { dashboardFetch } = await import('./gateway-capabilities')
const response = await dashboardFetch('/api/profiles', {
signal: AbortSignal.timeout(5000),
})
if (!response.ok) return null
Expand Down Expand Up @@ -314,12 +306,8 @@ export async function readProfileWithFallback(
const dashboardUrl = getDashboardUrl()
if (dashboardUrl) {
try {
const token = getDashboardToken()
const headers: Record<string, string> = {}
if (token) headers['Authorization'] = `Bearer ${token}`

const response = await fetch(`${dashboardUrl}/api/profiles`, {
headers,
const { dashboardFetch } = await import('./gateway-capabilities')
const response = await dashboardFetch('/api/profiles', {
signal: AbortSignal.timeout(5000),
})
if (response.ok) {
Expand Down