fix(sessions): persist renames in dashboard-without-enhancedChat mode - #715
Open
bdtsimon wants to merge 1 commit into
Open
fix(sessions): persist renames in dashboard-without-enhancedChat mode#715bdtsimon wants to merge 1 commit into
bdtsimon wants to merge 1 commit into
Conversation
When the gateway reports `dashboard.available && !enhancedChat`, the
PATCH /api/sessions handler returned `{ ok: true, updated: false }`
without saving anything. A rename in that mode looked like it succeeded
in the UI but never reached the agent, so the session kept its raw
first-message title on the native dashboard.
Persist the rename through `dashboardFetch` (PATCH /api/sessions/{id},
which resolves friendly ids), surface a real error when the dashboard
rejects it, and echo the saved title back to the client.
Reviewed by bdtsimon
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
In the
PATCH /api/sessionshandler, when the gateway reportscapabilities.dashboard.available && !capabilities.enhancedChat, the branch returned:…without persisting anything. A rename in that mode looks like it succeeded (the UI gets
ok: true), but nothing reaches the agent — the session keeps its raw first-message title on the native dashboard, and re-opening the list shows the old name.Fix
Persist the rename through the existing
dashboardFetchhelper —PATCH /api/sessions/{id}(which resolves friendly ids too) — surface a real error when the dashboard rejects it, and echo the saved title back to the client (updated: true).Single-concern, no new dependencies: it reuses
dashboardFetchfromserver/gateway-capabilitiesand mirrors the shape the other PATCH branches already return.Notes
updateSession()path (fullenhancedChat) and the local-session path are unchanged.{ ok: false }with the dashboard'sdetail(or a 502 when the dashboard is unreachable) instead of a false success.Reviewed by bdtsimon
🤖 Generated with Claude Code