Reduce memory usage of fs.readdir withFileTypes (#16897)

oven-sh · Jan 31, 2025 · 212944a · 212944a
1 parent 61bf221
commit 212944a
Show file tree

Hide file tree

Showing 11 changed files with 825 additions and 154 deletions.
diff --git a/.cursor/rules/javascriptcore-class.mdc b/.cursor/rules/javascriptcore-class.mdc
diff --git a/src/bun.js/base.zig b/src/bun.js/base.zig
@@ -72,6 +72,18 @@ pub fn toJS(globalObject: *JSC.JSGlobalObject, comptime ValueType: type, value:
         },
         JSC.JSValue => return if (Type != ValueType) value.* else value,
 
+        inline []const u16, []const u32, []const i16, []const i8, []const i32, []const f32 => {
+            var array = JSC.JSValue.createEmptyArray(globalObject, value.len);
+            for (value, 0..) |item, i| {
+                array.putIndex(
+                    globalObject,
+                    @truncate(i),
+                    JSC.jsNumber(item),
+                );
+            }
+            return array;
+        },
+
         else => {
 
             // Recursion can stack overflow here
@@ -80,7 +92,7 @@ pub fn toJS(globalObject: *JSC.JSGlobalObject, comptime ValueType: type, value:
 
                 var array = JSC.JSValue.createEmptyArray(globalObject, value.len);
                 for (value, 0..) |*item, i| {
-                    const res = toJS(globalObject, *const Child, item, lifetime);
+                    const res = toJS(globalObject, *Child, item, lifetime);
                     if (res == .zero) return .zero;
                     array.putIndex(
                         globalObject,

diff --git a/src/bun.js/bindings/JSX509CertificatePrototype.h b/src/bun.js/bindings/JSX509CertificatePrototype.h
@@ -10,9 +10,9 @@ class VM;
 
 namespace Bun {
 
-class JSX509CertificatePrototype final : public JSC::JSObject {
+class JSX509CertificatePrototype final : public JSC::JSNonFinalObject {
 public:
-    using Base = JSC::JSObject;
+    using Base = JSC::JSNonFinalObject;
     static constexpr unsigned StructureFlags = Base::StructureFlags;
 
     static JSX509CertificatePrototype* create(JSC::VM& vm, JSC::JSGlobalObject* globalObject, JSC::Structure* structure)