Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bun patch not working in monorepo #12103

Open
Scalahansolo opened this issue Jun 24, 2024 · 2 comments · May be fixed by #12141
Open

bun patch not working in monorepo #12103

Scalahansolo opened this issue Jun 24, 2024 · 2 comments · May be fixed by #12141
Assignees
@zackradisic
Labels
bug Something isn't working npm Something that relates to the npm-compatible client

Comments

@Scalahansolo
Copy link

What version of Bun is running?

1.1.16+bf7b327f6

What platform is your computer?

Darwin 23.4.0 arm64 arm

What steps can reproduce the bug?

Our monorepo contains plenty of apps / packages all defined in the root package.json workspaces array of our monorepo. After upgrading to bun 1.1.16 the following screen shot shows off the issue I am running into.

CleanShot 2024-06-23 at 21 35 07@2x

What is the expected behavior?

No response

What do you see instead?

No response

Additional information

No response
@Scalahansolo Scalahansolo added bug Something isn't working needs triage labels Jun 24, 2024
@Jarred-Sumner Jarred-Sumner added npm Something that relates to the npm-compatible client and removed needs triage labels Jun 24, 2024
@Scalahansolo
Copy link
Author

Opened as a response to #2336

@flokol120
Copy link

I am also experiencing problems while trying to use bun patch in a monorepo:

bun patch [email protected]
bun patch v1.1.16 (bf7b327f)

Checked 4260 installs across 2976 packages (no changes) [47.00ms]
error: error overwriting folder in node_modules: FileNotFound

ls node_modules/monaco-editor 
CHANGELOG.md  dev  esm  LICENSE  min  min-maps  monaco.d.ts  package.json  README.md  ThirdPartyNotices.txt

I was using the latest canary release (1.1.17-canary).

@zackradisic zackradisic linked a pull request Jun 25, 2024 that will close this issue
Open
@kravetsone kravetsone mentioned this issue Jun 27, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zackradisic zackradisic

Labels
bug Something isn't working npm Something that relates to the npm-compatible client
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

install: fix issues with patching hoisted dependencies in workspaces oven-sh/bun
4 participants
@Jarred-Sumner @Scalahansolo @flokol120 @zackradisic