Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

install: fix issues with patching hoisted dependencies in workspaces #12141

Merged
merged 6 commits into from
Jul 2, 2024

Conversation

zackradisic
Copy link
Contributor

What does this PR do?

Fixes #12103

Specifically the issue was bun patch not properly handling hoisted dependencies in workspaces

Copy link
Contributor

github-actions bot commented Jun 25, 2024

@dylan-conway, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/js/web/fetch/fetch.test.ts 1 failing

🐧💪 1 failing tests Linux AARCH64

  • test/integration/next-pages/test/next-build.test.ts 1 failing

🪟💻 4 failing tests Windows x64 baseline

  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/bun/io/bun-write.test.js 1 failing
  • test/js/node/child_process/child_process.test.ts 1 failing

🪟💻 3 failing tests Windows x64

  • test/cli/install/registry/bun-install-registry.test.ts 5 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/js/node/child_process/child_process.test.ts 1 failing

View logs

@Jarred-Sumner
Copy link
Collaborator

windows test failures

@Scalahansolo
Copy link

Was curious to know if this might be making it into a release soon? The team over here at Motion is pretty anxious to try and swap yarn out for bun at the install layer and we think this is the last blocker.

@flokol120
Copy link

Was curious to know if this might be making it into a release soon? The team over here at Motion is pretty anxious to try and swap yarn out for bun at the install layer and we think this is the last blocker.

Exactly the same situation over here. 😅

@Thiagolino8
Copy link

Was curious to know if this might be making it into a release soon? The team over here at Motion is pretty anxious to try and swap yarn out for bun at the install layer and we think this is the last blocker.

Same here

@dylan-conway
Copy link
Collaborator

@Scalahansolo @flokol120 @Thiagolino8 We plan to have this included in the next release (1.1.18). There isn't a date for the release yet, but I would expect first half of next week

@dylan-conway dylan-conway merged commit bf14a09 into main Jul 2, 2024
@dylan-conway dylan-conway deleted the zack/patch-fix-not-found-in-workpace branch July 2, 2024 00:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun patch not working in monorepo
6 participants