Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unusable postgres client behind a canary-or-debug-only feature flag #11920

Open
wants to merge 28 commits into
base: main
Choose a base branch
from

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

Bring back #6531

This isn't ready yet, but I don't want it to bitrot - so what if we merge this behind a canary/debug-only feature flag?

The main issues are:

  1. GC isn't being handled correctly when creating results, which leads to a crash after enough of the tests run. This makes it unusable for more than a brief period
  2. TLS is not at all implemented yet
  3. Only prepared statements are supported
  4. No helper for transactions
  5. Only SCRAM-SHA-256 password auth is implemented. MD5 digest, GSSPI, TLS, etc are not implemented yet.
  6. Error messages from Postgres are almost unreadable
  7. Various polish details are not implemented. sql.array, command property, number of changes, no way to transform values etc. I think we could get away with shipping a v1 that lacks most polish details though

How did you verify your code works?

@Jarred-Sumner Jarred-Sumner changed the title Add barely usable postgres client behind a canary-or-debug-only feature flag Add unusable postgres client behind a canary-or-debug-only feature flag Jun 17, 2024
Copy link
Contributor

github-actions bot commented Jun 17, 2024

@Jarred-Sumner, your commit has failing tests :(

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/bun-add.test.ts 1 failing
  • test/cli/install/registry/bun-install-registry.test.ts 1 failing
  • test/integration/expo-app/expo.test.ts 1 failing

🪟💻 3 failing tests Windows x64

  • test/cli/install/bun-add.test.ts 1 failing
  • test/cli/install/registry/bun-install-windowsshim.test.ts code 1
  • test/integration/next-pages/test/dev-server.test.ts 1 failing

View logs

src/bun.js/bindings/structure.cpp Outdated Show resolved Hide resolved
src/bun.js/bindings/structure.cpp Outdated Show resolved Hide resolved
src/sql/postgres.zig Show resolved Hide resolved
src/sql/postgres.zig Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants