-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unusable postgres client behind a canary-or-debug-only feature flag #11920
Open
Jarred-Sumner
wants to merge
28
commits into
main
Choose a base branch
from
jarred/jarredpostgresql3
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
Jarred-Sumner
changed the title
Add barely usable postgres client behind a canary-or-debug-only feature flag
Add unusable postgres client behind a canary-or-debug-only feature flag
Jun 17, 2024
❌ @Jarred-Sumner, your commit has failing tests :( 🪟💻 3 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Bring back #6531
This isn't ready yet, but I don't want it to bitrot - so what if we merge this behind a canary/debug-only feature flag?
The main issues are:
SCRAM-SHA-256
password auth is implemented. MD5 digest, GSSPI, TLS, etc are not implemented yet.sql.array
,command
property, number of changes, no way to transform values etc. I think we could get away with shipping a v1 that lacks most polish details thoughHow did you verify your code works?