Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: enable error return traces in release build #12024

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

paperdave
Copy link
Collaborator

What does this PR do?

For more context on what an Error Return Trace is, view https://ziglang.org/documentation/0.13.0/#Error-Return-Traces

This PR enables a feature I implemented at the time of writing the new Crash reporter, which is --verbose-error-trace, which for all caught Zig errors, it will dump the error in the form of a report view URL. This applies for all errors that return from main, but also any place we call bun.handleErrorReturnTrace, which ideally is at every place we catch ... without bubbling up the error or handling it specially.

Have not noticed any observable performance differences. More testing there is needed.

Copy link
Contributor

@paperdave, your commit has failing tests :(

💪 1 failing tests Darwin AARCH64

  • test/js/web/workers/worker.test.ts 1 failing

🪟💻 3 failing tests Windows x64 baseline

  • test/cli/install/migration/complex-workspace.test.ts 21 failing
  • test/js/bun/http/serve-body-leak.test.ts 1 failing
  • test/js/bun/shell/shell-hang.test.ts 3 failing

🪟💻 2 failing tests Windows x64

  • test/integration/next-pages/test/dev-server.test.ts 1 failing
  • test/js/bun/shell/shell-hang.test.ts 1 failing

View logs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants