install: Detect cross-FS cache directory and find best one #12126
+286
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Dylan Conway <[email protected]>
Co-authored-by: Jarred Sumner <[email protected]> Co-authored-by: Dylan Conway <[email protected]>
…ixes in markdown syntax (#12025) Co-authored-by: dave caruso <[email protected]>
Co-authored-by: paperdave <[email protected]>
Co-authored-by: dylan-conway <[email protected]>
Co-authored-by: zackradisic <[email protected]> Co-authored-by: Jarred Sumner <[email protected]>
Co-authored-by: dylan-conway <[email protected]>
Co-authored-by: Jarred Sumner <[email protected]> Co-authored-by: dave caruso <[email protected]>
| tmpname: [:0]const u8, | ||
| ) bool { | ||
| // Make sure cachedir and cwd are in the same filesystem | ||
| std.posix.renameatZ(dir_with_file_to_rename.fd, tmpname, dir_to_rename_file_to.fd, tmpname) catch return false; |
There was a problem hiding this comment.
None of these should be using std.posix
There was a problem hiding this comment.
and this doesn't test they're in the same filesystem. This tests it doesn't throw an error.
There was a problem hiding this comment.
and it shouldn't be in bun.sys unless it's reusable elsewhere
| /// Invariants: | ||
| /// | ||
| /// - node_modules_folder_path is absolute path with no relative syntax | ||
| pub fn findBestDirectoryInSameFileSystem( |
There was a problem hiding this comment.
This can go in the package manager code
we don't need to do this elsewhere afaict
|
❌ @zackradisic, your commit has failing tests :( 💪 1 failing tests Darwin AARCH64
💻 1 failing tests Darwin x64 baseline
💻 1 failing tests Darwin x64
🐧💪 1 failing tests Linux AARCH64
🐧🖥 1 failing tests Linux x64 baseline
🐧🖥 1 failing tests Linux x64
🪟💻 3 failing tests Windows x64 baseline
🪟💻 3 failing tests Windows x64
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
WIP need tests
Right now in the package manager, on initialization, we select an install cache directory and a temp directory that are on the same filesystem. This is because copy/moving files between filesystems is slow.
However, we don't ensure that the cache directory and the user's project directory (directory where
package.jsonis) are on the same file system. If this is the case, thenbun installbecomes very slow.This PR detects if the cache directory is on another filesystem from the project directory. If that is the case, then we either: