feat(bundler): implement enum inlining / more constant folding #12144
+2,100
−1,567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
❌ @paperdave, your commit has failing tests :( 💪 15 failing tests Darwin AARCH64
💻 15 failing tests Darwin x64 baseline
💻 15 failing tests Darwin x64
🐧💪 15 failing tests Linux AARCH64
🐧🖥 16 failing tests Linux x64 baseline
🐧🖥 15 failing tests Linux x64
🪟💻 22 failing tests Windows x64 baseline
🪟💻 22 failing tests Windows x64
|
paperdave
changed the title
paperdave
force-pushed
the
dave/the-enum-pr
branch
from
76e7420
to
3aec7f1
Compare
This comment was marked as outdated.
This comment was marked as outdated.
paperdave
commented
Jun 29, 2024
| /// by calling out to the APIs in WebKit which are responsible for this operation. | ||
| /// | ||
| /// This can return `null` in wasm builds to avoid linking JSC | ||
| pub fn toString(this: Number, allocator: std.mem.Allocator) ?string { |
There was a problem hiding this comment.
note: this is renamed from toStringSafely to toString, not because it is now less safe, but because the original intent of "we are taking a safer approach" does not apply.
| @@ -123,7 +123,7 @@ pub fn getOSGlibCVersion(os: OperatingSystem) ?Version { | |||
| } | |||
|
|
|||
| pub fn build(b: *Build) !void { | |||
| std.debug.print("zig build v{s}\n", .{builtin.zig_version_string}); | |||
| std.log.info("zig compiler v{s}", .{builtin.zig_version_string}); | |||
There was a problem hiding this comment.
apologies for doing a ton of other random things in this pr. i fixed the banned.json linter which resulted in needing to apply a ton of small transformations. i did this because i was sick of std.debug.print showing at all in my cmd+shift+f menu. this also resulted in the deletion of some old files, which some did not even past astgen.
additionally, i have been using a client side spell-checker, so it just becomes annoying to see a ton of yellow underlines. maybe i will upstream a ci check to keep spelling somewhat intact (i have been very impressed with the typos cli and lsp, it is very low false positive).
| @compileError("This function can only be called in comptime."); | ||
| } | ||
| var x = 0; // if you hit an error on this line, you are not in a comptime context | ||
| _ = &x; | ||
| } |
There was a problem hiding this comment.
comptime @inComptime is a compiler error in 0.14 and in 0.13 does not do what we want.
| @@ -46,8 +46,6 @@ pub const allow_json_single_quotes = true; | |||
|
|
|||
| pub const react_specific_warnings = true; | |||
|
|
|||
| pub const log_allocations = false; | |||
There was a problem hiding this comment.
this behavior is now provided via BUN_DEBUG_mimalloc=1
| const use = part.symbol_uses.getPtr(ref).?; | ||
|
|
||
| // Rare path: this import is a TypeScript enum | ||
| if (c.graph.meta.items(.imports_to_bind)[id].get(ref)) |import_data| { |
There was a problem hiding this comment.
Please hoist this .items[id] call above the for loop
| /// generated proxy symbols that represent the property access "x3.y". This | ||
| /// map is unique per namespace block because "x3" is the argument symbol that | ||
| /// is specific to that particular namespace block. | ||
| property_accesses: std.StringArrayHashMapUnmanaged(Ref) = .{}, |
There was a problem hiding this comment.
Suggested change
| property_accesses: std.StringArrayHashMapUnmanaged(Ref) = .{}, | |
| property_accesses: bun.StringArrayHashMapUnmanaged(Ref) = .{}, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11764
Fixes #2945
Fixes #2889
Draft TODO:
Initially was a PR to fix an enum bug, but it turned out the bug was due to a lack of a feature: enum inlining. So I decided to do it, since it was a feature I personally have a big use for (For example, the
bun.reportproject has a regex hack workaround to force enum inlining, because the codegen otherwise is an abomination)Simple Sample
After:
Before:
If you reference the enum directly, you can get the two-way map. This even works with
const enum, as it is TSC's job to prohibit such usage.The codegen of these enums have been improved. Projects with heavy enum usage should see smaller bundle sizes. Now:
Before:
It would be interesting as a future project to see if the size of these enums could be shrunk further, but
esbuilddoesn't do that, and I think personally it's fine to leaveenumin the dust asconst enumand inlining all values becomes the new norm.