Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(install): bun pm trust with updated dependencies #12215

Merged
merged 4 commits into from
Jun 28, 2024

Conversation

dylan-conway
Copy link
Collaborator

@dylan-conway dylan-conway commented Jun 27, 2024

What does this PR do?

This fixes a bug that can happen when all dependencies are trusted, bun update is run and new untrusted dependencies are added, then bun pm trust --all is run. The original code was assuming all node_modules folders above the deepest node_modules folder would have scripts to run.

fixes #12151

How did you verify your code works?

added a test running bun pm trust --all when scripts only exist below root node_modules

@robobun
Copy link

robobun commented Jun 27, 2024

@dylan-conway, your commit 62f58a1 has 17 failures in #442:

  • test/cli/hot/watch.test.ts - timeout on 🪟 x64
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/node/child_process/child_process.test.ts - 1 failing on 🪟 x64
  • test/napi/napi.test.ts - 8 failing on 🪟 x64
  • test/napi/napi.test.ts - 8 failing on 🪟 x64-baseline
  • test/cli/hot/hot.test.ts - 5 failing on 🪟 x64
  • test/cli/hot/hot.test.ts - 4 failing on 🪟 x64-baseline
  • test/cli/hot/hot.test.ts - 5 failing on 🪟 x64
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 12 x64-baseline
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 20.04 x64-baseline
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 22.04 x64
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 12 x64
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 20.04 x64
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 22.04 x64-baseline
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 20.04 aarch64
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 12 aarch64
  • test/js/bun/glob/scan.test.ts - 2 failing on 🐧 22.04 aarch64
  • test/cli/watch/watch.test.ts - 1 failing on 🪟 x64
  • test/cli/watch/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/cli/watch/watch.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 20.04 x64-baseline (smoke)
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 20.04 x64-baseline
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 22.04 x64
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 20.04 x64
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 22.04 x64-baseline
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 20.04 aarch64
  • test/js/bun/dns/resolve-dns.test.ts - segmentation fault on 🐧 22.04 aarch64
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64-baseline (smoke)
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64
  • test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🪟 x64
  • test/regression/issue/07500/07500.test.ts - 1 failing on 🪟 x64-baseline
  • test/js/bun/udp/udp_socket.test.ts - timeout on 🍎 13 aarch64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 20.04 aarch64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 22.04 aarch64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 12 aarch64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 22.04 x64-baseline
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 20.04 x64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 12 x64-baseline
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 22.04 x64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 12 x64
  • test/js/third_party/grpc-js/test-retry.test.ts - timeout on 🐧 20.04 x64-baseline
  • test/bundler/bundler_edgecase.test.ts - segmentation fault on 🪟 x64
  • test/bundler/bundler_edgecase.test.ts - segmentation fault on 🪟 x64-baseline
  • test/bundler/bundler_edgecase.test.ts - segmentation fault on 🪟 x64
  • test/bundler/bundler_edgecase.test.ts - segmentation fault on 🪟 x64-baseline
  • test/bundler/bundler_edgecase.test.ts - segmentation fault on 🪟 x64-baseline
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 12 x64
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 20.04 x64-baseline (smoke)
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/web/workers/worker.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/bun/udp/dgram.test.ts - timeout on 🍎 13 aarch64
  • test/js/node/fs/fs.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/node/worker_threads/worker_threads.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/node/worker_threads/worker_threads.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/node/worker_threads/worker_threads.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/node/worker_threads/worker_threads.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/node/worker_threads/worker_threads.test.ts - 1 failing on 🐧 12 x64
  • test/js/node/worker_threads/worker_threads.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 22.04 x64-baseline
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 12 x64-baseline
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 12 x64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 20.04 x64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 20.04 x64-baseline
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 22.04 x64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 20.04 aarch64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 22.04 aarch64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🐧 12 aarch64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🪟 x64
  • test/js/web/fetch/fetch-gzip.test.ts - 1 failing on 🪟 x64-baseline
  • @Jarred-Sumner Jarred-Sumner merged commit d5aa726 into main Jun 28, 2024
    63 of 67 checks passed
    @Jarred-Sumner Jarred-Sumner deleted the dylan/fix-12151 branch June 28, 2024 23:51
    Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
    Labels
    None yet
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    Bug with bun pm trust --all
    3 participants