wip rewrite web streams API in c++ #15843

Jarred-Sumner · 2024-12-18T13:01:25Z

What does this PR do?

Documentation or TypeScript types (it's okay to leave the rest blank in this case)
Code changes

How did you verify your code works?

robobun · 2024-12-18T13:01:35Z

^{Updated 3:01 PM PT - Dec 27th, 2024}

❌ @Jarred-Sumner, your commit 4e5cae8 has 64 failures in #8584:

test/js/node/http/node-fetch.test.js - 1 failing on 🍎 13 aarch64
test/js/deno/fetch/body.test.ts - 1 failing on 🍎 14 aarch64
test/js/deno/fetch/body.test.ts - 1 failing on 🍎 14 aarch64
test/js/node/child_process/child_process.test.ts - timeout on 🍎 14 aarch64
test/js/node/child_process/child_process.test.ts - timeout on 🍎 13 aarch64
test/js/node/child_process/child_process.test.ts - timeout on 🍎 13 x64
test/js/bun/util/sleep.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/sleep.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/util/sleep.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/sleep.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/util/readablestreamtoarraybuffer.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/readablestreamtoarraybuffer.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/util/readablestreamtoarraybuffer.test.ts - 1 failing on 🍎 13 x64
test/js/bun/util/readablestreamtoarraybuffer.test.ts - 1 failing on 🍎 14 x64
test/js/bun/util/readablestreamtoarraybuffer.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/readablestreamtoarraybuffer.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 14 x64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 13 x64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 14 x64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/util/fuzzy-wuzzy.test.ts - 1 failing on 🍎 13 x64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 14 aarch64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 14 x64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 13 aarch64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 13 x64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 14 x64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 14 aarch64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 13 aarch64
test/js/bun/util/filesink.test.ts - 18 failing on 🍎 13 x64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 14 aarch64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 14 x64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 13 aarch64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 13 x64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 14 x64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 14 aarch64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 13 aarch64
test/js/bun/test/test-test.test.ts - 4 failing on 🍎 13 x64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 14 aarch64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 14 x64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 13 aarch64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 13 x64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 14 x64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 14 aarch64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 13 aarch64
test/js/bun/stream/direct-readable-stream.test.tsx - 228 failing on 🍎 13 x64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 14 aarch64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 14 x64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 13 aarch64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 13 x64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 14 x64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 14 aarch64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 13 aarch64
test/js/bun/spawn/spawn.test.ts - timeout on 🍎 13 x64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 14 aarch64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 13 aarch64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 13 x64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 14 x64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 14 aarch64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 14 x64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 13 x64
test/js/node/child_process/child-process-stdio.test.js - 5 failing on 🍎 13 aarch64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 14 aarch64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 13 aarch64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 13 x64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 14 x64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 14 aarch64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 14 x64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 13 x64
test/js/node/async_hooks/AsyncLocalStorage.test.ts - SIGTRAP on 🍎 13 aarch64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 14 aarch64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 13 aarch64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 13 x64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 14 x64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 14 aarch64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 14 x64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 13 x64
test/js/first_party/undici/undici.test.ts - 6 failing on 🍎 13 aarch64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 14 aarch64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 13 aarch64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 13 x64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 14 x64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 14 aarch64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 14 x64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 13 x64
test/js/deno/fetch/blob.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-streaming-stdout.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-stream-serve.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stress.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 13 x64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 14 x64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 14 x64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 13 x64
test/js/bun/spawn/spawn-empty-arrayBufferOrBlob.test.ts - 3 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-streaming-stdin.test.ts - 1 failing on 🍎 13 x64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 14 aarch64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 13 aarch64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 13 x64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 14 x64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 14 aarch64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 14 x64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 13 x64
test/js/bun/shell/env.positionals.test.ts - 4 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/spawn-stdin-destroy.test.ts - 1 failing on 🍎 13 x64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 14 aarch64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 13 aarch64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 13 x64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 14 x64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 14 aarch64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 14 x64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 13 x64
test/js/bun/shell/bunshell.test.ts - 6 failing on 🍎 13 aarch64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 14 x64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 14 aarch64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 13 x64
test/js/bun/spawn/job-object-bug.test.ts - 1 failing on 🍎 13 aarch64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 14 aarch64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 13 aarch64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 13 x64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 14 x64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 14 aarch64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 14 x64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 13 x64
test/js/bun/net/socket.test.ts - 2 failing on 🍎 13 aarch64
test/js/bun/http/serve.test.ts - segmentation fault on 🍎 14 aarch64
test/js/bun/http/serve.test.ts - SIGTRAP on 🍎 14 x64
test/js/bun/http/serve.test.ts - segmentation fault on 🍎 13 aarch64
test/js/bun/http/serve.test.ts - SIGTRAP on 🍎 13 x64
test/js/bun/http/serve.test.ts - SIGTRAP on 🍎 14 x64
test/js/bun/http/serve.test.ts - segmentation fault on 🍎 14 aarch64
test/js/bun/http/serve.test.ts - SIGTRAP on 🍎 13 x64
test/js/bun/http/serve.test.ts - segmentation fault on 🍎 13 aarch64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 14 aarch64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 13 aarch64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 13 x64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 14 x64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 14 aarch64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 14 x64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 13 x64
test/js/bun/io/bun-write.test.js - 1 failing on 🍎 13 aarch64

🧪 try this PR locally:

bunx bun-pr 15843

Jarred-Sumner added 2 commits December 18, 2024 02:55

wip

fbe1895

more

64df1de

Jarred-Sumner added 27 commits December 18, 2024 15:23

Create ReadableStream.mjs

83e813f

Merge branch 'main' into jarred/streamy-

110f94d

Update BunWritableStream.cpp

14e8c47

Create .cursorignore

38f98d3

wip

3a39b18

more

c2b9ea2

Fix more errors

be1631d

Update BunReadableStreamDefaultController.h

7bff270

more

33db844

more

7c2b935

Update BunWritableStream.cpp

fcb0dae

more

c76ad94

Update .cursorignore

9894605

move some things around

b152f07

More files

a03502e

More files

bdab548

More files

d76d8b7

More files

20c8bb1

Update BunReadableStream.h

c25bb29

More files

7997706

More files

5fc5baa

Update BunWritableStreamConstructor.h

4f6b066

More files

49647de

More

d03f88a

Update BunReadableStreamDefaultReaderConstructor.cpp

cfc3907

Update BunReadableStreamDefaultController.cpp

122e875

more

00b9b94

Jarred-Sumner and others added 17 commits December 20, 2024 00:17

more

665e1f8

Merge branch 'main' into jarred/streamy-

f08c1a3

more

6c4d833

It compiled

c04bef6

delete probably too much code

9127371

there's more

98e130a

more

dbdceef

much

243b087

wip

cfcef4b

it compiled once again

9bea782

We are streaming

44714cb

Update BunReadableStreamDefaultReader.cpp

c22d1a6

Update BunReadableStream.h

44465a8

sort of owrks

1e34965

working better

1f6e67c

Update ReadableStream.mjs

bdcb6ec

bun run prettier:extra

4e5cae8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

wip rewrite web streams API in c++ #15843

wip rewrite web streams API in c++ #15843

Jarred-Sumner commented Dec 18, 2024

robobun commented Dec 18, 2024 •

edited

Loading

wip rewrite web streams API in c++ #15843

Are you sure you want to change the base?

wip rewrite web streams API in c++ #15843

Conversation

Jarred-Sumner commented Dec 18, 2024

What does this PR do?

How did you verify your code works?

robobun commented Dec 18, 2024 • edited Loading

robobun commented Dec 18, 2024 •

edited

Loading