Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: avoid hitting MAX_PATHLEN in win32 builds #16299

Merged
merged 3 commits into from
Jan 10, 2025

Conversation

DonIsaac
Copy link
Contributor

@DonIsaac DonIsaac commented Jan 9, 2025

What does this PR do?

Branches with long names can be just enough to put paths to cached webkit header/object files past windows' max path length of 4096 260. Discovered in #16294. Example here

@DonIsaac DonIsaac added the build An issue related to building or compiling label Jan 9, 2025
@DonIsaac DonIsaac requested a review from Electroid January 9, 2025 23:43
@robobun
Copy link

robobun commented Jan 9, 2025

Updated 5:16 PM PT - Jan 9th, 2025

@DonIsaac, your commit a069d63 has passed in #9334! 🎉


🧪   try this PR locally:

bunx bun-pr 16299

@Jarred-Sumner
Copy link
Collaborator

where is 4096 as the max path length coming from?

@DonIsaac
Copy link
Contributor Author

My mistake, it's actually 260.

@DonIsaac DonIsaac added this pull request to the merge queue Jan 10, 2025
Merged via the queue into main with commit b4d9223 Jan 10, 2025
69 checks passed
@DonIsaac DonIsaac deleted the don/build/avoid-win32-max-pathlen branch January 10, 2025 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build An issue related to building or compiling
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants