feat: load full certificate bundles from NODE_EXTRA_CA_CERTS
#16782
+370
−123
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShlomoCode
force-pushed
the
main
branch
2 times, most recently
from
0304e37 to
98b16af
Compare
ShlomoCode
force-pushed
the
main
branch
2 times, most recently
from
062e57f to
8b38e9f
Compare
|
@cirospaciari Would you mind taking a look? Thank you! |
cirospaciari
requested changes
Feb 6, 2025
ShlomoCode
force-pushed
the
main
branch
2 times, most recently
from
8ea761b to
a38b1ac
Compare
ShlomoCode
force-pushed
the
main
branch
2 times, most recently
from
b905456 to
830ac77
Compare
cirospaciari
requested changes
Feb 11, 2025
| ERR_error_string_n(ERR_peek_last_error(), buf, sizeof(buf)); | ||
| char msg[512]; | ||
| snprintf(msg, sizeof(msg), "ignoring extra certs from `%s`, load failed: %s", filename, buf); | ||
| bun_log_warn(msg); |
There was a problem hiding this comment.
instead of snprintf can you pass filename and buf to bun_log_warn and handle it there?
also can you call ERR_clear_error after logging?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Closes #13867
How did you verify your code works?
I added tests.
P.S.
Inspired by Node.js' approach (https://github.com/nodejs/node/blob/main/src/crypto/crypto_context.cc#L215-L236 - https://github.com/nodejs/node/blob/main/src/crypto/crypto_context.cc#L565-L577)