fix(sql) fix execution queue#16854
Merged
Jarred-Sumner merged 30 commits intomainfrom Jan 30, 2025
Merged
Conversation
Collaborator
|
Updated 11:44 PM PT - Jan 29th, 2025
❌ @cirospaciari, your commit 9aae5be has 2 failures in
🧪 try this PR locally: bunx bun-pr 16854 |
ac90cb3 to
2bf1462
Compare
bc5b2d8 to
a6b0bce
Compare
…ck to match behavior from postgres
Collaborator
|
The lack of new tests does not inspire confidence |
Jarred-Sumner
approved these changes
Jan 30, 2025
Collaborator
Jarred-Sumner
left a comment
There was a problem hiding this comment.
I'm going to merge this, but please follow-up with tests.
Member
Author
somehow this test got lost on my latest commit 26b62ef opening a PR to re-add it |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix: #16774
Fix: #16892
How did you verify your code works?
Test