Skip to content

fix(sql) fix execution queue#16854

Merged
Jarred-Sumner merged 30 commits intomainfrom
ciro/fix-postgres-queue
Jan 30, 2025
Merged

fix(sql) fix execution queue#16854
Jarred-Sumner merged 30 commits intomainfrom
ciro/fix-postgres-queue

Conversation

@cirospaciari
Copy link
Copy Markdown
Member

@cirospaciari cirospaciari commented Jan 29, 2025

What does this PR do?

Fix: #16774
Fix: #16892

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Test

@robobun
Copy link
Copy Markdown
Collaborator

robobun commented Jan 29, 2025

Updated 11:44 PM PT - Jan 29th, 2025

@cirospaciari, your commit 9aae5be has 2 failures in Build #10829:


🧪   try this PR locally:

bunx bun-pr 16854

@cirospaciari cirospaciari changed the title Ciro/fix postgres queue fix(sql) Concurrency statements execution error in BunSQL Jan 29, 2025
@cirospaciari cirospaciari changed the title fix(sql) Concurrency statements execution error in BunSQL fix(sql) fix execution queue states Jan 29, 2025
@cirospaciari cirospaciari force-pushed the ciro/fix-postgres-queue branch from ac90cb3 to 2bf1462 Compare January 29, 2025 01:53
@cirospaciari cirospaciari marked this pull request as ready for review January 29, 2025 01:53
@cirospaciari cirospaciari changed the title fix(sql) fix execution queue states fix(sql) fix execution queue Jan 29, 2025
@cirospaciari cirospaciari force-pushed the ciro/fix-postgres-queue branch from bc5b2d8 to a6b0bce Compare January 29, 2025 08:16
@Jarred-Sumner
Copy link
Copy Markdown
Collaborator

The lack of new tests does not inspire confidence

Copy link
Copy Markdown
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm going to merge this, but please follow-up with tests.

@Jarred-Sumner Jarred-Sumner merged commit 892764e into main Jan 30, 2025
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-postgres-queue branch January 30, 2025 07:52
@cirospaciari
Copy link
Copy Markdown
Member Author

The lack of new tests does not inspire confidence

somehow this test got lost on my latest commit 26b62ef opening a PR to re-add it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SQL from bun gets timeouts very easly Concurrency statements execution error in BunSQL

3 participants