Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make passing an signal: AbortSignal.timeout to fetch implicitly set timeout: false #16859

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Jarred-Sumner
Copy link
Collaborator

What does this PR do?

This makes passing an signal: AbortSignal.timeout to fetch implicitly set timeout: false

If you do

fetch(url, {signal: AbortSignal.timeout(60*1024*20)});

You expect the fetch call to timeout after 20 minutes. You don't expect it to timeout after 5 minutes because you forgot to set timeout to false.

How did you verify your code works?

@robobun
Copy link

robobun commented Jan 29, 2025

Updated 7:25 PM PT - Jan 28th, 2025

@Jarred-Sumner, your commit 7589b86 has 1 failures in Build #10735:


🧪   try this PR locally:

bunx bun-pr 16859

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants