zig: update to 0.14.0-dev [wip] #16862
Draft
+1,731
−2,148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Updated 6:09 PM PT - Jan 29th, 2025
❌ @nektro, your commit 0e407c5 has 1 failures in
🧪 try this PR locally: bunx bun-pr 16862 |
nektro
changed the title
| @@ -524,63 +524,54 @@ pub const AspectRatio = struct { | |||
| }; | |||
|
|
|||
| pub const BackgroundProperty = packed struct(u16) { | |||
| @"background-color": bool = false, | |||
There was a problem hiding this comment.
it's clearer to keep it as the exact CSS property name. Instead of having to mentally ask "is it background-color or is it color?
| @@ -568,79 +568,79 @@ const BorderShorthand = struct { | |||
| }; | |||
|
|
|||
| const BorderProperty = packed struct(u32) { | |||
| @"border-top-color": bool = false, | |||
| @@ -1385,14 +1381,14 @@ pub fn NewPackageInstall(comptime kind: PkgInstallKind) type { | |||
| Method.hardlink; | |||
|
|
|||
| fn installWithClonefileEachDir(this: *@This(), destination_dir: std.fs.Dir) !Result { | |||
| var cached_package_dir = bun.openDir(this.cache_dir, this.cache_dir_subpath) catch |err| return Result.fail(err, .opening_cache_dir, @errorReturnTrace()); | |||
| var cached_package_dir = bun.openDir(this.cache_dir, this.cache_dir_subpath) catch |err| return Result.initFail(err, .opening_cache_dir, @errorReturnTrace()); | |||
There was a problem hiding this comment.
We can't keep it as init? It's clearer imo
| @@ -493,7 +493,7 @@ pub const StreamStart = union(Tag) { | |||
| close: bool = false, | |||
| mode: bun.Mode = 0o664, | |||
|
|
|||
| pub fn flags(this: *const FileSinkOptions) bun.Mode { | |||
| pub fn flags(this: *const FileSinkOptions) c_int { | |||
There was a problem hiding this comment.
can this be i32 at least
nektro
changed the title
after looking through them, i suspect most can be removed without additional changes. some need to change related atomic accesses (see ziglang/zig#21585) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on:
@fence?