Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(s3) fix queue and multipart flow #16890

Merged
merged 16 commits into from
Jan 31, 2025
Merged

fix(s3) fix queue and multipart flow #16890

merged 16 commits into from
Jan 31, 2025

Conversation

cirospaciari
Copy link
Member

What does this PR do?

Fix: #16781

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

Tests

Sorry, something went wrong.

@robobun
Copy link

robobun commented Jan 30, 2025

Updated 5:20 AM PT - Jan 31st, 2025

@Jarred-Sumner, your commit abe96ff has 1 failures in Build #10915:


🧪   try this PR locally:

bunx bun-pr 16890

Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you want to pre-allocate, then this should be a slice and not an ArrayList.

Keeping it as an ArrayList is a footgun.

@cirospaciari cirospaciari force-pushed the ciro/fix-s3-multipart branch from 02c8f51 to 686d8da Compare January 31, 2025 00:10
@cirospaciari cirospaciari marked this pull request as ready for review January 31, 2025 00:10
@cirospaciari cirospaciari marked this pull request as draft January 31, 2025 00:17
@cirospaciari cirospaciari marked this pull request as ready for review January 31, 2025 00:46
@cirospaciari cirospaciari marked this pull request as draft January 31, 2025 00:51
@cirospaciari cirospaciari marked this pull request as ready for review January 31, 2025 00:59
Copy link
Collaborator

@Jarred-Sumner Jarred-Sumner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs more tests. There should be tests for different queue sizes, for different amounts of writes, for writes that exceed the queue size, for writes that never exceed the queue size.

@Jarred-Sumner Jarred-Sumner merged commit 25f6cbd into main Jan 31, 2025
67 of 69 checks passed
@Jarred-Sumner Jarred-Sumner deleted the ciro/fix-s3-multipart branch January 31, 2025 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

S3 stream upload crashes Bun
3 participants