-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(s3) fix queue and multipart flow #16890
Conversation
Updated 5:20 AM PT - Jan 31st, 2025
❌ @Jarred-Sumner, your commit abe96ff has 1 failures in
🧪 try this PR locally: bunx bun-pr 16890 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you want to pre-allocate, then this should be a slice and not an ArrayList.
Keeping it as an ArrayList is a footgun.
02c8f51
to
686d8da
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs more tests. There should be tests for different queue sizes, for different amounts of writes, for writes that exceed the queue size, for writes that never exceed the queue size.
What does this PR do?
Fix: #16781
How did you verify your code works?
Tests