-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental hot module reloading for HTML import development mode #16955
Draft
paperclover
wants to merge
21
commits into
main
Choose a base branch
from
chloe/hmr
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+2,904
−2,298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated 5:23 PM PT - Feb 5th, 2025
❌ @paperclover, your commit 01c03df has some failures in 🧪 try this PR locally: bunx bun-pr 16955 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DevServer gains a new type of RouteBundle for HTML imports. HTML imports have no server files, but may co-exist alongside server routes. While only SPA-style apps are supported now, the tech supports RSC in the same graph as these HTML route bundles.
Instead of
framework: "react"
, the framework option is currently unspecifiable. To allow React to 'just work', the default framework will automatically configurereact-refresh
if it is installed. If onlyreact
is installed, then an embedded copy ofreact-refresh
is enabled to make that also 'just work'.This PR also resolves some but not all requirements to use HMR reliably, so I still call it experimental. It is very close though.