-
Notifications
You must be signed in to change notification settings - Fork 2.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bun pm pack
support "files"
starting with ./
#17135
Conversation
Updated 1:22 AM PT - Feb 8th, 2025
❌ @RiskyMH, your commit d911de7 has 1 failures in
🧪 try this PR locally: bunx bun-pr 17135 |
bun pm pack
support files starting with ./
bun pm pack
support "files"
starting with ./
Do we need to do path normalization in general or specifically just ./? |
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we need to do path normalization in general or specifically just ./?
I think we need this. ./index.js
and ./////index.js
should both normalize to index.js
. I suggest calling bun.path.normalizeBuf()
on the input before passing to Pattern.fromUTF8
.
Co-authored-by: Dylan Conway <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, when tests pass let's merge
What does this PR do?
fixes #17134
How did you verify your code works?
made a test + tested with
npm
for intended outcomes!./
actually doesn't do anything on npm