Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bun pm pack support "files" starting with ./ #17135

Merged
merged 5 commits into from
Feb 8, 2025
Merged

Conversation

RiskyMH
Copy link
Member

@RiskyMH RiskyMH commented Feb 7, 2025

What does this PR do?

fixes #17134

  • Documentation or TypeScript types (it's okay to leave the rest blank in this case)
  • Code changes

How did you verify your code works?

made a test + tested with npm for intended outcomes

  • note that !./ actually doesn't do anything on npm

@RiskyMH RiskyMH requested a review from dylan-conway February 7, 2025 06:34
@robobun
Copy link

robobun commented Feb 7, 2025

Updated 1:22 AM PT - Feb 8th, 2025

@RiskyMH, your commit d911de7 has 1 failures in Build #11307:


🧪   try this PR locally:

bunx bun-pr 17135

@RiskyMH RiskyMH changed the title bun pm pack support files starting with ./ bun pm pack support "files" starting with ./ Feb 7, 2025
@Jarred-Sumner
Copy link
Collaborator

Do we need to do path normalization in general or specifically just ./?

@RiskyMH

This comment was marked as outdated.

Copy link
Member

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to do path normalization in general or specifically just ./?

I think we need this. ./index.js and ./////index.js should both normalize to index.js. I suggest calling bun.path.normalizeBuf() on the input before passing to Pattern.fromUTF8.

Copy link
Member

@dylan-conway dylan-conway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, when tests pass let's merge

@dylan-conway dylan-conway merged commit 584db03 into main Feb 8, 2025
67 of 69 checks passed
@dylan-conway dylan-conway deleted the riskymh/pm-pack-fixes branch February 8, 2025 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bun publish does not pack files correctly
4 participants